Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1933403002: Revert "Implements support for ignoring method type arguments in resolution." (Closed)

Created:
4 years, 7 months ago by eernst
Modified:
4 years, 7 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, floitsch
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Implements support for ignoring method type arguments in resolution." This reverts commit e44e667ca7a57eb98050b43c3d6b084c1604a3bd, because that commit introduced many timeouts on dart2js-jsshell, ia32. Committed: https://github.com/dart-lang/sdk/commit/c2d18fe0655da0ac626492d04b7b24e8fe3d86e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -265 lines) Patch
M pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart View 4 chunks +0 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 8 chunks +14 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 9 chunks +4 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 5 chunks +13 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 3 chunks +2 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 8 chunks +12 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/scope.dart View 3 chunks +12 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 7 chunks +7 lines, -50 lines 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 2 chunks +1 line, -7 lines 0 comments Download
M pkg/compiler/lib/src/resolution/typedefs.dart View 1 chunk +1 line, -7 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 3 chunks +0 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 5 chunks +2 lines, -14 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 4 chunks +6 lines, -22 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 6 chunks +20 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
eernst
TBR: Many timeouts suddenly occurred on dart2js-jsshell ia32 tests, hence the reversal.
4 years, 7 months ago (2016-04-29 19:34:31 UTC) #2
eernst
Committed patchset #1 (id:1) manually as c2d18fe0655da0ac626492d04b7b24e8fe3d86e8 (presubmit successful).
4 years, 7 months ago (2016-04-29 19:37:07 UTC) #4
Johnni Winther
LGTM Massive timeouts still occur after the revert so your CL was falsely accused.
4 years, 7 months ago (2016-04-30 08:45:39 UTC) #5
eernst
4 years, 7 months ago (2016-05-02 07:26:48 UTC) #6
Message was sent while issue was closed.
On 2016/04/30 08:45:39, Johnni Winther wrote:
> LGTM
> 
> Massive timeouts still occur after the revert so your CL was falsely accused.

That was also my interpretation, but `build.py .. -aia32 ..` failed so I
couldn't verify locally that it worked.

Powered by Google App Engine
This is Rietveld 408576698