Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1933383002: Workaround #537 (Closed)

Created:
4 years, 7 months ago by vsm
Modified:
4 years, 7 months ago
Reviewers:
Jacob
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M lib/runtime/dart_sdk.js View 2 chunks +3 lines, -3 lines 0 comments Download
M tool/input_sdk/lib/js/dart2js/js_dart2js.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tool/sdk_expected_errors.txt View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
vsm
This gets ng2 hello world working again.
4 years, 7 months ago (2016-04-29 19:24:03 UTC) #2
Jacob
lgtm
4 years, 7 months ago (2016-04-29 19:43:32 UTC) #3
vsm
4 years, 7 months ago (2016-04-29 19:47:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b07d5201530f5bf0346d1ba35dfde3cb3a002777 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698