Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 1933373002: DevTools: Move network pane on timeline out of experiment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: formatting Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1288 matching lines...) Expand 10 before | Expand all | Expand 10 after
1299 1299
1300 this._splitWidget = new WebInspector.SplitWidget(false, false, "timelineFlam echartMainView", 150); 1300 this._splitWidget = new WebInspector.SplitWidget(false, false, "timelineFlam echartMainView", 150);
1301 1301
1302 this._dataProvider = new WebInspector.TimelineFlameChartDataProvider(this._m odel, frameModel, irModel, filters); 1302 this._dataProvider = new WebInspector.TimelineFlameChartDataProvider(this._m odel, frameModel, irModel, filters);
1303 var mainViewGroupExpansionSetting = WebInspector.settings.createSetting("tim elineFlamechartMainViewGroupExpansion", {}); 1303 var mainViewGroupExpansionSetting = WebInspector.settings.createSetting("tim elineFlamechartMainViewGroupExpansion", {});
1304 this._mainView = new WebInspector.FlameChart(this._dataProvider, this, mainV iewGroupExpansionSetting); 1304 this._mainView = new WebInspector.FlameChart(this._dataProvider, this, mainV iewGroupExpansionSetting);
1305 1305
1306 this._networkDataProvider = new WebInspector.TimelineFlameChartNetworkDataPr ovider(this._model); 1306 this._networkDataProvider = new WebInspector.TimelineFlameChartNetworkDataPr ovider(this._model);
1307 this._networkView = new WebInspector.FlameChart(this._networkDataProvider, t his); 1307 this._networkView = new WebInspector.FlameChart(this._networkDataProvider, t his);
1308 1308
1309 if (Runtime.experiments.isEnabled("networkRequestsOnTimeline")) { 1309 this._splitWidget.setMainWidget(this._mainView);
1310 this._splitWidget.setMainWidget(this._mainView); 1310 this._splitWidget.setSidebarWidget(this._networkView);
1311 this._splitWidget.setSidebarWidget(this._networkView); 1311 this._splitWidget.show(this.element);
1312 this._splitWidget.show(this.element);
1313 } else {
1314 this._mainView.show(this.element);
1315 }
1316 1312
1317 this._onMainEntrySelected = this._onEntrySelected.bind(this, this._dataProvi der); 1313 this._onMainEntrySelected = this._onEntrySelected.bind(this, this._dataProvi der);
1318 this._onNetworkEntrySelected = this._onEntrySelected.bind(this, this._networ kDataProvider); 1314 this._onNetworkEntrySelected = this._onEntrySelected.bind(this, this._networ kDataProvider);
1319 this._mainView.addEventListener(WebInspector.FlameChart.Events.EntrySelected , this._onMainEntrySelected, this); 1315 this._mainView.addEventListener(WebInspector.FlameChart.Events.EntrySelected , this._onMainEntrySelected, this);
1320 this._networkView.addEventListener(WebInspector.FlameChart.Events.EntrySelec ted, this._onNetworkEntrySelected, this); 1316 this._networkView.addEventListener(WebInspector.FlameChart.Events.EntrySelec ted, this._onNetworkEntrySelected, this);
1321 WebInspector.blackboxManager.addChangeListener(this.refreshRecords, this); 1317 WebInspector.blackboxManager.addChangeListener(this.refreshRecords, this);
1322 } 1318 }
1323 1319
1324 WebInspector.TimelineFlameChartView.prototype = { 1320 WebInspector.TimelineFlameChartView.prototype = {
1325 /** 1321 /**
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
1486 /** 1482 /**
1487 * @constructor 1483 * @constructor
1488 * @param {!WebInspector.TimelineSelection} selection 1484 * @param {!WebInspector.TimelineSelection} selection
1489 * @param {number} entryIndex 1485 * @param {number} entryIndex
1490 */ 1486 */
1491 WebInspector.TimelineFlameChartView.Selection = function(selection, entryIndex) 1487 WebInspector.TimelineFlameChartView.Selection = function(selection, entryIndex)
1492 { 1488 {
1493 this.timelineSelection = selection; 1489 this.timelineSelection = selection;
1494 this.entryIndex = entryIndex; 1490 this.entryIndex = entryIndex;
1495 } 1491 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698