Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

Issue 1933373002: DevTools: Move network pane on timeline out of experiment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 362 matching lines...) Expand 10 before | Expand all | Expand 10 after
373 var clearButton = new WebInspector.ToolbarButton(WebInspector.UIString(" Clear recording"), "clear-toolbar-item"); 373 var clearButton = new WebInspector.ToolbarButton(WebInspector.UIString(" Clear recording"), "clear-toolbar-item");
374 clearButton.addEventListener("click", this._clear, this); 374 clearButton.addEventListener("click", this._clear, this);
375 this._panelToolbar.appendToolbarItem(clearButton); 375 this._panelToolbar.appendToolbarItem(clearButton);
376 376
377 this._panelToolbar.appendSeparator(); 377 this._panelToolbar.appendSeparator();
378 378
379 this._panelToolbar.appendText(WebInspector.UIString("Capture:")); 379 this._panelToolbar.appendText(WebInspector.UIString("Capture:"));
380 380
381 this._captureNetworkSetting.addChangeListener(this._onNetworkChanged, th is); 381 this._captureNetworkSetting.addChangeListener(this._onNetworkChanged, th is);
382 if (!Runtime.experiments.isEnabled("timelineRecordingPerspectives") || p erspectiveSetting.get() === WebInspector.TimelinePanel.Perspectives.Custom) { 382 if (!Runtime.experiments.isEnabled("timelineRecordingPerspectives") || p erspectiveSetting.get() === WebInspector.TimelinePanel.Perspectives.Custom) {
383 if (Runtime.experiments.isEnabled("networkRequestsOnTimeline")) { 383 this._panelToolbar.appendToolbarItem(this._createSettingCheckbox(Web Inspector.UIString("Network"),
384 this._panelToolbar.appendToolbarItem(this._createSettingCheckbox (WebInspector.UIString("Network"), 384 thi s._captureNetworkSetting,
caseq 2016/05/02 17:32:43 style: let's use indent of 4 here.
385 this._captureNetworkSetting, 385 Web Inspector.UIString("Capture network requests information")));
caseq 2016/05/02 17:32:43 s/Capture/Show/?
386 WebInspector.UIString("Capture network requests information")));
387 }
388 this._panelToolbar.appendToolbarItem(this._createSettingCheckbox(Web Inspector.UIString("JS Profile"), 386 this._panelToolbar.appendToolbarItem(this._createSettingCheckbox(Web Inspector.UIString("JS Profile"),
389 thi s._captureJSProfileSetting, 387 thi s._captureJSProfileSetting,
390 Web Inspector.UIString("Capture JavaScript stacks with sampling profiler. (Has perfo rmance overhead)"))); 388 Web Inspector.UIString("Capture JavaScript stacks with sampling profiler. (Has perfo rmance overhead)")));
391 this._captureMemorySetting.addChangeListener(this._onModeChanged, th is); 389 this._captureMemorySetting.addChangeListener(this._onModeChanged, th is);
392 this._panelToolbar.appendToolbarItem(this._createSettingCheckbox(Web Inspector.UIString("Memory"), 390 this._panelToolbar.appendToolbarItem(this._createSettingCheckbox(Web Inspector.UIString("Memory"),
393 thi s._captureMemorySetting, 391 thi s._captureMemorySetting,
394 Web Inspector.UIString("Capture memory information on every timeline event."))); 392 Web Inspector.UIString("Capture memory information on every timeline event.")));
395 this._panelToolbar.appendToolbarItem(this._createSettingCheckbox(Web Inspector.UIString("Paint"), 393 this._panelToolbar.appendToolbarItem(this._createSettingCheckbox(Web Inspector.UIString("Paint"),
396 thi s._captureLayersAndPicturesSetting, 394 thi s._captureLayersAndPicturesSetting,
397 Web Inspector.UIString("Capture graphics layer positions and painted pictures. (Has performance overhead)"))); 395 Web Inspector.UIString("Capture graphics layer positions and painted pictures. (Has performance overhead)")));
(...skipping 1669 matching lines...) Expand 10 before | Expand all | Expand 10 after
2067 * @override 2065 * @override
2068 * @param {!WebInspector.Target} target 2066 * @param {!WebInspector.Target} target
2069 */ 2067 */
2070 targetRemoved: function(target) 2068 targetRemoved: function(target)
2071 { 2069 {
2072 this._targets.remove(target, true); 2070 this._targets.remove(target, true);
2073 }, 2071 },
2074 2072
2075 __proto__: WebInspector.Object.prototype 2073 __proto__: WebInspector.Object.prototype
2076 } 2074 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698