Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1933373002: DevTools: Move network pane on timeline out of experiment (Closed)

Created:
4 years, 7 months ago by alph
Modified:
4 years, 7 months ago
Reviewers:
paulirish, caseq
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Move network pane on timeline out of experiment BUG=464370 Committed: https://crrev.com/261f7cb4ee33780e4cdd3b9b0be547c7a17dc0dd Cr-Commit-Position: refs/heads/master@{#391010}

Patch Set 1 #

Total comments: 2

Patch Set 2 : formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -22 lines) Patch
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 chunk +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js View 1 1 chunk +8 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
alph
4 years, 7 months ago (2016-04-29 19:03:38 UTC) #2
paulirish
lgtm
4 years, 7 months ago (2016-04-29 19:13:04 UTC) #3
caseq
https://codereview.chromium.org/1933373002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js (right): https://codereview.chromium.org/1933373002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js#newcode384 third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:384: this._captureNetworkSetting, style: let's use indent of 4 here. https://codereview.chromium.org/1933373002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js#newcode385 ...
4 years, 7 months ago (2016-05-02 17:32:44 UTC) #4
caseq
lgtm
4 years, 7 months ago (2016-05-02 17:32:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933373002/20001
4 years, 7 months ago (2016-05-02 17:38:20 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-02 18:48:05 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 18:49:30 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/261f7cb4ee33780e4cdd3b9b0be547c7a17dc0dd
Cr-Commit-Position: refs/heads/master@{#391010}

Powered by Google App Engine
This is Rietveld 408576698