Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1933363002: UBSan vptr: disable broken test suites on the new GN buildbot. (Closed)

Created:
4 years, 7 months ago by krasin
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke, dpranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

UBSan vptr: disable broken test suites on the new GN buildbot. They were never run on the GYP buildbot and a separate cleanup is required. BUG=607996 Committed: https://crrev.com/a6fd652c54e83981deb84d61fa2b7af8f9797a54 Cr-Commit-Position: refs/heads/master@{#390777}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -40 lines) Patch
M testing/buildbot/chromium.fyi.json View 6 chunks +0 lines, -40 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
krasin
4 years, 7 months ago (2016-04-29 18:58:59 UTC) #2
Dirk Pranke
lgtm
4 years, 7 months ago (2016-04-29 19:15:15 UTC) #4
krasin
On 2016/04/29 19:15:15, Dirk Pranke wrote: > lgtm Thank you, Dirk!
4 years, 7 months ago (2016-04-29 19:48:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933363002/1
4 years, 7 months ago (2016-04-29 19:49:00 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 22:00:31 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:29:28 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6fd652c54e83981deb84d61fa2b7af8f9797a54
Cr-Commit-Position: refs/heads/master@{#390777}

Powered by Google App Engine
This is Rietveld 408576698