Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Issue 1933343002: Do not accept CSS identifiers for format() (Closed)

Created:
4 years, 7 months ago by rwlbuis
Modified:
4 years, 7 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not accept CSS identifiers for format() According to [1] format() must be of type <string>, so do not accept CSS identifiers any longer. Behavior matched Firefox. [1] https://drafts.csswg.org/css-fonts/#src-desc Committed: https://crrev.com/38d79508a1367a88cb66354fc47d6d939d7b7621 Cr-Commit-Position: refs/heads/master@{#391198}

Patch Set 1 #

Patch Set 2 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/fontfaceset-download-error.html View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/fontfaceset-multiple-families.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/loader/font-face-empty.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
rwlbuis
PTAL.
4 years, 7 months ago (2016-05-02 02:39:09 UTC) #5
Timothy Loh
On 2016/05/02 02:39:09, rwlbuis wrote: > PTAL. lgtm
4 years, 7 months ago (2016-05-03 08:06:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933343002/20001
4 years, 7 months ago (2016-05-03 10:05:22 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-03 11:09:10 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 11:10:15 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/38d79508a1367a88cb66354fc47d6d939d7b7621
Cr-Commit-Position: refs/heads/master@{#391198}

Powered by Google App Engine
This is Rietveld 408576698