Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1933323002: GN: Add common header extensions (Closed)

Created:
4 years, 7 months ago by NGG
Modified:
4 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Add common header extensions GN now recognizes most common header file extensions: *.h, *.hh, *.hpp, *.hxx These are all used inside the chromium repository. This change makes "gn check" more robust. R=brettw@chromium.org BUG= Committed: https://crrev.com/cc00b4093699e76fb09489ede68c1eb3fb4b0db7 Cr-Commit-Position: refs/heads/master@{#391056}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/gn/source_file_type.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
NGG
4 years, 7 months ago (2016-04-29 16:45:35 UTC) #1
brettw
lgtm
4 years, 7 months ago (2016-05-02 17:05:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933323002/1
4 years, 7 months ago (2016-05-02 20:34:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 21:25:22 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 21:27:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc00b4093699e76fb09489ede68c1eb3fb4b0db7
Cr-Commit-Position: refs/heads/master@{#391056}

Powered by Google App Engine
This is Rietveld 408576698