scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_blink_trybot.json - Issue 1933223002: Chromium: make use of new get_files_affected_by_patch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_blink_trybot.json

Issue 1933223002: Chromium: make use of new get_files_affected_by_patch. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipes/chromium_trybot.py ('K') | « scripts/slave/recipes/chromium_trybot.expected/too_many_failures_for_retcode.json ('k') | scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_blink_trybot.json

diff --git a/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_blink_trybot.json b/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_blink_trybot.json

index 1d76bb79d0d711dde1ff5c91cdc15b279a4ae5c1..ce0d65782db359ad48658cc86c5b3fcc86937831 100644

--- a/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_blink_trybot.json

+++ b/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_blink_trybot.json

@@ -232,13 +232,13 @@

"--cached",

"--name-only"

- "cwd": "[SLAVE_BUILD]/src",

+ "cwd": "[SLAVE_BUILD]/src/third_party/skia",

rmistry 2016/04/29 16:40:45 This looks much better.

"name": "git diff to analyze patch",

"stdout": "/path/to/tmp/",

"~followup_annotations": [

- "@@@STEP_LOG_LINE@files@foo.cc@@@",

+ "@@@STEP_LOG_LINE@files@src/third_party/skia/foo.cc@@@",

"@@@STEP_LOG_END@files@@@",

- "@@@SET_BUILD_PROPERTY@subproject_tag@\"chromium\"@@@"

+ "@@@SET_BUILD_PROPERTY@subproject_tag@\"blink-paths\"@@@"

]

{

@@ -278,7 +278,7 @@

"mac_blink_rel",

"-v",

"//out/Release",

- "{\"additional_compile_targets\": [], \"files\": [\"foo.cc\"], \"test_targets\": [\"blink_tests\"]}",

+ "{\"additional_compile_targets\": [], \"files\": [\"third_party/skia/foo.cc\"], \"test_targets\": [\"blink_tests\"]}",

"/path/to/tmp/json"

"env": {