Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1933203002: Import web-platform-tests@343606cdf8f6c7442d1a0309a9fcdd47d6244eca (Closed)

Created:
4 years, 7 months ago by dtapuska
Modified:
4 years, 7 months ago
Reviewers:
tdresser
CC:
chromium-reviews, blink-reviews, tfarina, blink-reviews-w3ctests_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Import web-platform-tests@343606cdf8f6c7442d1a0309a9fcdd47d6244eca Using update-w3c-deps in Blink bc50dbff7fa0b25e644d80effef731f169063ad6. Activate importing of the now merged uievents web platform tests. BUG=606934 Committed: https://crrev.com/3d00b723c1e406fbb7f3dc952eaf048c752c9d1a Cr-Commit-Position: refs/heads/master@{#390699}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Mark new media stream test as flaky #

Patch Set 3 : Rebase against web-platform tests to pick up my whitespace fix upstream #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2441 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/W3CImportExpectations View 3 chunks +3 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/html/syntax/serializing-html-fragments/initial-linefeed-pre.html View 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/html/syntax/serializing-html-fragments/initial-linefeed-pre-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-preload-none.html View 1 chunk +58 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/touch-events/historical.html View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/ClickFakeEvent.nondocument.html View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/README.md View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/constructors/README.md View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/constructors/constructors.html View 1 chunk +153 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/constructors/constructors-expected.txt View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/hierarchy/README.md View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/interface/README.md View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/keyboard/README.md View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/keyboard/key-manual.css View 1 chunk +118 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/keyboard/key-manual.js View 1 chunk +671 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/legacy-domevents-tests/approved/DOM.event.flow.html View 1 2 1 chunk +64 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/legacy-domevents-tests/approved/EventListener.eventHandler.html View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/legacy-domevents-tests/approved/EventObject.multiple.dispatchEvent.html View 1 2 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/legacy-domevents-tests/approved/EventObject.multiple.dispatchEvent-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/legacy-domevents-tests/approved/ProcessingInstruction.DOMCharacterDataModified.html View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/legacy-domevents-tests/approved/dispatchEvent.click.checkbox.html View 1 2 1 chunk +80 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/legacy-domevents-tests/approved/domnodeinserted.html View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/legacy-domevents-tests/approved/stopImmediatePropagation.effect.html View 1 2 1 chunk +71 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/legacy-domevents-tests/approved/stopPropagation.deferred.effect.html View 1 2 1 chunk +70 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/legacy-domevents-tests/approved/support/ProcessingInstruction.DOMCharacterDataModified.xml View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/legacy-domevents-tests/submissions/Microsoft/converted/EventListener.dispatch.new.event.html View 1 chunk +77 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/legacy-domevents-tests/submissions/Microsoft/converted/support/ProcessingInstruction.DOMCharacterDataModified.xml View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/legacy-domevents-tests/submissions/Microsoft/support/16kb.js View 1 2 1 chunk +140 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/legacy-domevents-tests/submissions/Microsoft/support/InvalidBitMap.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/legacy-domevents-tests/submissions/Microsoft/support/iepreview.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/legacy-domevents-tests/submissions/Microsoft/support/style01.css View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/order-of-events/README.md View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/order-of-events/event-phases-order.html View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/order-of-events/init-event-while-dispatching.html View 1 chunk +83 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/order-of-events/init-event-while-dispatching-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/resources/eventrecorder.js View 1 chunk +283 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/throwing-in-listener-and-window-error-event.html View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/throwing-in-listener-and-window-error-event-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/uievents/throwing-in-listener-when-all-have-not-run-yet.html View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
dtapuska
Just need a review from another committer.
4 years, 7 months ago (2016-04-29 14:18:40 UTC) #3
tdresser
https://codereview.chromium.org/1933203002/diff/1/third_party/WebKit/LayoutTests/W3CImportExpectations File third_party/WebKit/LayoutTests/W3CImportExpectations (right): https://codereview.chromium.org/1933203002/diff/1/third_party/WebKit/LayoutTests/W3CImportExpectations#newcode327 third_party/WebKit/LayoutTests/W3CImportExpectations:327: imported/web-platform-tests/uievents/OWNERS [ Skip ] Does this file exist?
4 years, 7 months ago (2016-04-29 14:23:13 UTC) #4
tdresser
LGTM with nit.
4 years, 7 months ago (2016-04-29 14:23:55 UTC) #5
dtapuska
On 2016/04/29 14:23:13, tdresser wrote: > https://codereview.chromium.org/1933203002/diff/1/third_party/WebKit/LayoutTests/W3CImportExpectations > File third_party/WebKit/LayoutTests/W3CImportExpectations (right): > > https://codereview.chromium.org/1933203002/diff/1/third_party/WebKit/LayoutTests/W3CImportExpectations#newcode327 > ...
4 years, 7 months ago (2016-04-29 14:24:08 UTC) #6
tdresser
LGTM
4 years, 7 months ago (2016-04-29 14:24:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933203002/20001
4 years, 7 months ago (2016-04-29 15:32:18 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/175259)
4 years, 7 months ago (2016-04-29 15:40:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933203002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933203002/40001
4 years, 7 months ago (2016-04-29 17:01:16 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-04-29 18:17:12 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:27:24 UTC) #18
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/3d00b723c1e406fbb7f3dc952eaf048c752c9d1a
Cr-Commit-Position: refs/heads/master@{#390699}

Powered by Google App Engine
This is Rietveld 408576698