third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp - Issue 1933183002: Move isEmptyValue and emptyValue to SVGCharacterData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

Issue 1933183002: Move isEmptyValue and emptyValue to SVGCharacterData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

index 510baa3d026e8007d6e81dde1996cd277287704a..be198979b20e1466ace49b058141aca5a733c93c 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

@@ -141,7 +141,7 @@ bool LayoutSVGInlineText::characterStartsNewTextChunk(int position) const

if (it == m_layoutAttributes.characterDataMap().end())

return false;

- return !SVGTextLayoutAttributes::isEmptyValue(it->value.x) || !SVGTextLayoutAttributes::isEmptyValue(it->value.y);

+ return it->value.hasX() || it->value.hasY();

}

PositionWithAffinity LayoutSVGInlineText::positionForPoint(const LayoutPoint& point)

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributes.h » ('j') | no next file with comments »