Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1933183002: Move isEmptyValue and emptyValue to SVGCharacterData (Closed)

Created:
4 years, 7 months ago by fs
Modified:
4 years, 7 months ago
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move isEmptyValue and emptyValue to SVGCharacterData These two helpers have a stronger tie to SVGCharacterData (on which they operate) than to SVGTextLayoutAttributes - where they are currently defined. Move them as described, and also add simple query helpers to make code using them simpler and more readable. BUG=607906 Committed: https://crrev.com/7f48ba3851fc5c37187da843a4ffe3b9fe9a4045 Cr-Commit-Position: refs/heads/master@{#390649}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -13 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributes.h View 2 chunks +14 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
fs
4 years, 7 months ago (2016-04-29 13:44:24 UTC) #4
f(malita)
lgtm
4 years, 7 months ago (2016-04-29 14:49:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933183002/1
4 years, 7 months ago (2016-04-29 15:03:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 15:07:25 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:25:51 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f48ba3851fc5c37187da843a4ffe3b9fe9a4045
Cr-Commit-Position: refs/heads/master@{#390649}

Powered by Google App Engine
This is Rietveld 408576698