Pepper: Move GetSandboxISA() to PPB_NaCl_Private.

components/nacl/renderer/sandbox_isa.cc

+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// The list of supported ISA strings for x86.  See issue:
+//   http://code.google.com/p/nativeclient/issues/detail?id=1040 for more
+// information.  Note that these string are to be case-insensitive compared.
+
+#include "base/logging.h"
+#if defined(OS_WIN)
+#include "base/win/windows_version.h"
+#endif
+
+const char* const kNexeArchARM = "arm";
+const char* const kNexeArchMIPS = "mips32";
+const char* const kNexeArchX86_32 = "x86-32";
+const char* const kNexeArchX86_64 = "x86-64";
+
+namespace nacl {
+
+const char* GetSandboxISA() {
+#if defined(ARCH_CPU_ARM_FAMILY)
+  return kNexeArchArm;
+#elif defined(ARCH_CPU_MIPS_FAMILY)
+  return kNexeArchMIPS;
+#elif defined(ARCH_CPU_X86_FAMILY)
+
+#if defined(OS_WIN)
+  if (base::win::OSInfo::GetInstance()->architecture() == X64_ARCHITECTURE)

[dmichael (off chromium), 2014/03/11 21:58:04]

Wasn't there a comment at some point about checking the host (not target)
architecture? It's subtle enough it might be nice to comment.

+    return kNexeArchX86_64;
+  else
+    return kNexeArchX86_32;
+#else
+#if ARCH_CPU_64_BITS

[dmichael (off chromium), 2014/03/11 21:58:04]

optional nit: #elif might be clearer?

+    return kNexeArchX86_64;
+#else
+    return kNexeArchX86_32;
+#endif  // defined(OS_WIN)
+
+#else
+#error Architecture not supported.
+  NOTREACHED();
+  return NULL;
+#endif
+}
+
+}  // namespace nacl