Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1933113002: Web Animations: Clip animation active intervals if endDelay is negative (Closed)

Created:
4 years, 7 months ago by alancutter (OOO until 2018)
Modified:
4 years, 7 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-style_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web Animations: Clip animation active intervals if endDelay is negative This change updates our implementation of animation phases to match a recent spec change. Now the after phase begins at min(start delay + active duration, end time) where end time is start delay + active duration + end delay. The behavioural result of this is negative values for endDelay will "clip" into the animation's active interval. http://w3c.github.io/web-animations/#animation-effect-phases-and-states BUG=600248 Committed: https://crrev.com/1ceb7e51509ec80935c26d21658517216b52d8c0 Cr-Commit-Position: refs/heads/master@{#390886}

Patch Set 1 #

Messages

Total messages: 12 (5 generated)
alancutter (OOO until 2018)
4 years, 7 months ago (2016-04-29 09:58:01 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933113002/1
4 years, 7 months ago (2016-04-29 09:58:28 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/175138)
4 years, 7 months ago (2016-04-29 10:05:08 UTC) #6
suzyh_UTC10 (ex-contributor)
lgtm
4 years, 7 months ago (2016-05-02 00:05:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933113002/1
4 years, 7 months ago (2016-05-02 01:01:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 02:27:34 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 02:28:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ceb7e51509ec80935c26d21658517216b52d8c0
Cr-Commit-Position: refs/heads/master@{#390886}

Powered by Google App Engine
This is Rietveld 408576698