Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 19331002: Associate an id with the output surface to handle lost contexts (Closed)

Created:
7 years, 5 months ago by piman
Modified:
7 years, 5 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, Sami
Visibility:
Public.

Description

Associate an id with the output surface to handle lost contexts This lets us cull acks that were meant for a previous output surface, so that we don't try to return/release resources that have been destroyed already. BUG=239931 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212470

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix android, tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -50 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 3 chunks +13 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 7 chunks +12 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 2 chunks +6 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 9 chunks +23 lines, -13 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_guest.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_guest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/render_view_host_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/browser_plugin/browser_plugin_messages.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/common/view_messages.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/port/browser/render_widget_host_view_port.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/browser_plugin/browser_plugin_compositing_helper.h View 3 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_compositing_helper.cc View 12 chunks +17 lines, -2 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.h View 2 chunks +4 lines, -1 line 0 comments Download
M content/renderer/gpu/compositor_output_surface.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M content/renderer/gpu/delegated_compositor_output_surface.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/delegated_compositor_output_surface.cc View 1 chunk +6 lines, -1 line 0 comments Download
M content/renderer/gpu/mailbox_output_surface.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/gpu/mailbox_output_surface.cc View 3 chunks +15 lines, -3 lines 0 comments Download
M content/renderer/render_widget.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 3 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
piman
sievers: content/browser/renderer_host/render_widget_host_view_android.*, content/renderer/gpu/mailbox_output_surface.* alexst: content/browser/browser_plugin/browser_plugin_guest.*, content/browser/renderer_host/render_widget_host_view_guest.*, content/renderer/browser_plugin/* danakj: the rest palmer: IPC
7 years, 5 months ago (2013-07-16 04:23:05 UTC) #1
piman
https://codereview.chromium.org/19331002/diff/1/content/renderer/render_widget.cc File content/renderer/render_widget.cc (right): https://codereview.chromium.org/19331002/diff/1/content/renderer/render_widget.cc#newcode641 content/renderer/render_widget.cc:641: return factory->CreateOutputSurface(routing_id()); note: I believe we don't need to ...
7 years, 5 months ago (2013-07-16 04:24:30 UTC) #2
alexst (slow to review)
browser plugin lgtm
7 years, 5 months ago (2013-07-16 13:33:03 UTC) #3
no sievers
On 2013/07/16 04:23:05, piman wrote: > sievers: content/browser/renderer_host/render_widget_host_view_android.*, lgtm > content/renderer/gpu/mailbox_output_surface.* > alexst: content/browser/browser_plugin/browser_plugin_guest.*, > ...
7 years, 5 months ago (2013-07-16 16:46:26 UTC) #4
palmer
IPC security LGTM
7 years, 5 months ago (2013-07-16 19:28:19 UTC) #5
danakj
LGTM
7 years, 5 months ago (2013-07-17 21:07:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/19331002/6001
7 years, 5 months ago (2013-07-18 19:10:33 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-07-18 23:02:32 UTC) #8
Message was sent while issue was closed.
Change committed as 212470

Powered by Google App Engine
This is Rietveld 408576698