Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1298)

Unified Diff: blimp/net/blimp_message_multiplexer.h

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added oneof to protocol_control.proto Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/net/blimp_message_multiplexer.h
diff --git a/blimp/net/blimp_message_multiplexer.h b/blimp/net/blimp_message_multiplexer.h
index 8101edbbbf75846f42d1a25fd1b281be17f8e8e3..5dad1bfb8da74b8a58651ee920cd792bda2bc564 100644
--- a/blimp/net/blimp_message_multiplexer.h
+++ b/blimp/net/blimp_message_multiplexer.h
@@ -32,7 +32,7 @@ class BLIMP_NET_EXPORT BlimpMessageMultiplexer {
// Creates a BlimpMessageProcessor object for sending messages of type |type|.
Kevin M 2016/05/20 18:28:16 update documentation to reflect new naming
// Any number of senders can be created at a time for a given type.
std::unique_ptr<BlimpMessageProcessor> CreateSenderForType(
Kevin M 2016/05/20 18:28:16 The name "ForType" doesn't work anymore, since we
shaktisahu 2016/05/20 22:29:42 Done.
- BlimpMessage::Type type);
+ BlimpMessage::FeatureCase feature_case);
private:
base::WeakPtrFactory<BlimpMessageProcessor> output_weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698