Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: blimp/net/blimp_message_checkpointer.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added oneof to protocol_control.proto Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/net/blimp_message_checkpointer.cc
diff --git a/blimp/net/blimp_message_checkpointer.cc b/blimp/net/blimp_message_checkpointer.cc
index c9a20c37c6e4903e578d79fb90feac5d0304cafe..e1354da0cddd138c8be492492d4fc9dfda632777 100644
--- a/blimp/net/blimp_message_checkpointer.cc
+++ b/blimp/net/blimp_message_checkpointer.cc
@@ -35,9 +35,7 @@ BlimpMessageCheckpointer::~BlimpMessageCheckpointer() {}
void BlimpMessageCheckpointer::ProcessMessage(
std::unique_ptr<BlimpMessage> message,
const net::CompletionCallback& callback) {
- if (message->type() == BlimpMessage::PROTOCOL_CONTROL &&
- message->protocol_control().type() ==
- ProtocolControlMessage::CHECKPOINT_ACK) {
+ if (message->has_protocol_control()) {
Kevin M 2016/05/20 18:28:15 Check the feature case
shaktisahu 2016/05/20 22:29:41 Why? We are already doing that in the DCHECK above
if (message->protocol_control().has_checkpoint_ack() &&
Kevin M 2016/05/20 18:28:16 Check the case here too
shaktisahu 2016/05/20 22:29:41 Ditto
message->protocol_control().checkpoint_ack().has_checkpoint_id()) {
checkpoint_observer_->OnMessageCheckpoint(

Powered by Google App Engine
This is Rietveld 408576698