Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: blimp/net/blimp_message_demultiplexer_unittest.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Compared specific 'case' field into DCHECKs Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/net/blimp_message_demultiplexer_unittest.cc
diff --git a/blimp/net/blimp_message_demultiplexer_unittest.cc b/blimp/net/blimp_message_demultiplexer_unittest.cc
index de16fbc5b34aa81d237a24f89c5963176f9acfff..5e6e6d5568df27bc73aa3d42588032880851fda8 100644
--- a/blimp/net/blimp_message_demultiplexer_unittest.cc
+++ b/blimp/net/blimp_message_demultiplexer_unittest.cc
@@ -25,10 +25,10 @@ class BlimpMessageDemultiplexerTest : public testing::Test {
: input_msg_(new BlimpMessage), compositor_msg_(new BlimpMessage) {}
void SetUp() override {
- demux_.AddProcessor(BlimpMessage::INPUT, &receiver1_);
- demux_.AddProcessor(BlimpMessage::COMPOSITOR, &receiver2_);
- input_msg_->set_type(BlimpMessage::INPUT);
- compositor_msg_->set_type(BlimpMessage::COMPOSITOR);
+ demux_.AddProcessor(BlimpMessage::kInput, &receiver1_);
+ demux_.AddProcessor(BlimpMessage::kCompositor, &receiver2_);
+ input_msg_->mutable_input();
+ compositor_msg_->mutable_compositor();
}
protected:
@@ -61,7 +61,6 @@ TEST_F(BlimpMessageDemultiplexerTest, ProcessMessageFailed) {
TEST_F(BlimpMessageDemultiplexerTest, ProcessMessageNoRegisteredHandler) {
net::TestCompletionCallback cb;
std::unique_ptr<BlimpMessage> unknown_message(new BlimpMessage);
- unknown_message->set_type(BlimpMessage::UNKNOWN);
demux_.ProcessMessage(std::move(unknown_message), cb.callback());
EXPECT_EQ(net::ERR_NOT_IMPLEMENTED, cb.WaitForResult());
}

Powered by Google App Engine
This is Rietveld 408576698