Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1258)

Unified Diff: blimp/net/blimp_message_checkpointer_unittest.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Compared specific 'case' field into DCHECKs Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/net/blimp_message_checkpointer_unittest.cc
diff --git a/blimp/net/blimp_message_checkpointer_unittest.cc b/blimp/net/blimp_message_checkpointer_unittest.cc
index d498b46b72beb27ef3ac06569acb00a625574a4d..c36416429a5471614b33309fc443c1aeb27c693a 100644
--- a/blimp/net/blimp_message_checkpointer_unittest.cc
+++ b/blimp/net/blimp_message_checkpointer_unittest.cc
@@ -34,7 +34,7 @@ class MockCheckpointObserver : public BlimpMessageCheckpointObserver {
static std::unique_ptr<BlimpMessage> CreateExpectedAckMessage(int64_t id) {
std::unique_ptr<BlimpMessage> message = base::WrapUnique(new BlimpMessage);
- message->set_type(BlimpMessage::PROTOCOL_CONTROL);
+ message->mutable_protocol_control();
ProtocolControlMessage* protocol_control =
message->mutable_protocol_control();
protocol_control->set_type(ProtocolControlMessage::CHECKPOINT_ACK);
@@ -54,7 +54,7 @@ class BlimpMessageCheckpointerTest : public testing::Test {
int64_t SimulateIncomingMessage() {
std::unique_ptr<BlimpMessage> message(new BlimpMessage);
message->set_message_id(++message_id_);
- message->set_type(BlimpMessage::INPUT);
+ message->mutable_input();
checkpointer_->ProcessMessage(
std::move(message),
base::Bind(&BlimpMessageCheckpointerTest::IncomingCompletionCallback,

Powered by Google App Engine
This is Rietveld 408576698