blimp/engine/feature/engine_settings_feature.cc - Issue 1933053003: Used oneof in blimp_message.proto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/engine/feature/engine_settings_feature.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Compared specific 'case' field into DCHECKs Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/engine/feature/engine_settings_feature.cc

diff --git a/blimp/engine/feature/engine_settings_feature.cc b/blimp/engine/feature/engine_settings_feature.cc

index 65572c567cc3b275cfb31f31293bc4e517db8727..520d165580b654906e68a3ddfd421668883669d2 100644

--- a/blimp/engine/feature/engine_settings_feature.cc

+++ b/blimp/engine/feature/engine_settings_feature.cc

@@ -25,8 +25,7 @@ EngineSettingsFeature::~EngineSettingsFeature() {}

void EngineSettingsFeature::ProcessMessage(

std::unique_ptr<BlimpMessage> message,

const net::CompletionCallback& callback) {

- DCHECK_EQ(message->type(), BlimpMessage::SETTINGS);

- DCHECK(message->has_settings());

+ DCHECK_EQ(BlimpMessage::kSettings, message->feature_case());

const SettingsMessage& settings = message->settings();

DCHECK(settings.has_engine_settings());