Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2415)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: blimp/net/thread_pipe_manager.h

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/net/input_message_unittest.cc ('k') | blimp/net/thread_pipe_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/net/thread_pipe_manager.h
diff --git a/blimp/net/thread_pipe_manager.h b/blimp/net/thread_pipe_manager.h
index 01ec7d3e1649cdbff41e606a53dec463bd66e68c..9f074a585d146f60c1f6f659c514f97bba6bb179 100644
--- a/blimp/net/thread_pipe_manager.h
+++ b/blimp/net/thread_pipe_manager.h
@@ -39,10 +39,10 @@ class BLIMP_NET_EXPORT ThreadPipeManager {
~ThreadPipeManager();
// Registers a message processor |incoming_processor| which will receive all
- // messages of the |type| specified. Returns a BlimpMessageProcessor object
- // for sending messages of type |type|.
+ // messages of the |feature_case| specified. Returns a BlimpMessageProcessor
+ // object for sending messages of the given feature.
std::unique_ptr<BlimpMessageProcessor> RegisterFeature(
- BlimpMessage::Type type,
+ BlimpMessage::FeatureCase feature_case,
BlimpMessageProcessor* incoming_processor);
private:
« no previous file with comments | « blimp/net/input_message_unittest.cc ('k') | blimp/net/thread_pipe_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698