blimp/net/browser_connection_handler.cc - Issue 1933053003: Used oneof in blimp_message.proto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/net/browser_connection_handler.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/net/browser_connection_handler.cc

diff --git a/blimp/net/browser_connection_handler.cc b/blimp/net/browser_connection_handler.cc

index 1b4ea1dd8a65977cd77d2026e87d45275628e3a7..37519f7b9db40ca747886ab306e11324ba40367b 100644

--- a/blimp/net/browser_connection_handler.cc

+++ b/blimp/net/browser_connection_handler.cc

@@ -35,10 +35,10 @@ BrowserConnectionHandler::~BrowserConnectionHandler() {}

std::unique_ptr<BlimpMessageProcessor>

BrowserConnectionHandler::RegisterFeature(

- BlimpMessage::Type type,

+ BlimpMessage::FeatureCase feature_case,

BlimpMessageProcessor* incoming_processor) {

- demultiplexer_->AddProcessor(type, incoming_processor);

- return multiplexer_->CreateSenderForType(type);

+ demultiplexer_->AddProcessor(feature_case, incoming_processor);

+ return multiplexer_->CreateSender(feature_case);

}

void BrowserConnectionHandler::HandleConnection(