Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2788)

Unified Diff: blimp/net/blimp_message_demultiplexer_unittest.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/net/blimp_message_demultiplexer.cc ('k') | blimp/net/blimp_message_multiplexer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/net/blimp_message_demultiplexer_unittest.cc
diff --git a/blimp/net/blimp_message_demultiplexer_unittest.cc b/blimp/net/blimp_message_demultiplexer_unittest.cc
index de16fbc5b34aa81d237a24f89c5963176f9acfff..a4527a807b7cbc447e821c627b205b36fc9865aa 100644
--- a/blimp/net/blimp_message_demultiplexer_unittest.cc
+++ b/blimp/net/blimp_message_demultiplexer_unittest.cc
@@ -5,6 +5,7 @@
#include "blimp/net/blimp_message_demultiplexer.h"
#include "base/logging.h"
+#include "blimp/common/create_blimp_message.h"
#include "blimp/net/test_common.h"
#include "net/base/net_errors.h"
#include "net/base/test_completion_callback.h"
@@ -25,10 +26,12 @@ class BlimpMessageDemultiplexerTest : public testing::Test {
: input_msg_(new BlimpMessage), compositor_msg_(new BlimpMessage) {}
void SetUp() override {
- demux_.AddProcessor(BlimpMessage::INPUT, &receiver1_);
- demux_.AddProcessor(BlimpMessage::COMPOSITOR, &receiver2_);
- input_msg_->set_type(BlimpMessage::INPUT);
- compositor_msg_->set_type(BlimpMessage::COMPOSITOR);
+ demux_.AddProcessor(BlimpMessage::kInput, &receiver1_);
+ demux_.AddProcessor(BlimpMessage::kCompositor, &receiver2_);
+ InputMessage* input = nullptr;
+ input_msg_ = CreateBlimpMessage(&input);
+ CompositorMessage* compositor = nullptr;
+ compositor_msg_ = CreateBlimpMessage(&compositor, 1);
}
protected:
@@ -61,7 +64,6 @@ TEST_F(BlimpMessageDemultiplexerTest, ProcessMessageFailed) {
TEST_F(BlimpMessageDemultiplexerTest, ProcessMessageNoRegisteredHandler) {
net::TestCompletionCallback cb;
std::unique_ptr<BlimpMessage> unknown_message(new BlimpMessage);
- unknown_message->set_type(BlimpMessage::UNKNOWN);
demux_.ProcessMessage(std::move(unknown_message), cb.callback());
EXPECT_EQ(net::ERR_NOT_IMPLEMENTED, cb.WaitForResult());
}
« no previous file with comments | « blimp/net/blimp_message_demultiplexer.cc ('k') | blimp/net/blimp_message_multiplexer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698