Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Unified Diff: blimp/net/blimp_connection_unittest.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/engine/session/blimp_engine_session.cc ('k') | blimp/net/blimp_message_checkpointer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/net/blimp_connection_unittest.cc
diff --git a/blimp/net/blimp_connection_unittest.cc b/blimp/net/blimp_connection_unittest.cc
index 59c7a39a370f218e2a17c58283f87dd14d19822b..ee04e92c86508d450bb281e42448bb6f5963dc17 100644
--- a/blimp/net/blimp_connection_unittest.cc
+++ b/blimp/net/blimp_connection_unittest.cc
@@ -11,6 +11,7 @@
#include "base/callback_helpers.h"
#include "base/memory/ptr_util.h"
#include "base/message_loop/message_loop.h"
+#include "blimp/common/create_blimp_message.h"
#include "blimp/common/proto/blimp_message.pb.h"
#include "blimp/net/common.h"
#include "blimp/net/connection_error_observer.h"
@@ -48,15 +49,13 @@ class BlimpConnectionTest : public testing::Test {
protected:
std::unique_ptr<BlimpMessage> CreateInputMessage() {
- std::unique_ptr<BlimpMessage> msg(new BlimpMessage);
- msg->set_type(BlimpMessage::INPUT);
- return msg;
+ InputMessage* input;
+ return CreateBlimpMessage(&input);
}
std::unique_ptr<BlimpMessage> CreateControlMessage() {
- std::unique_ptr<BlimpMessage> msg(new BlimpMessage);
- msg->set_type(BlimpMessage::TAB_CONTROL);
- return msg;
+ TabControlMessage* control;
+ return CreateBlimpMessage(&control);
}
base::MessageLoop message_loop_;
« no previous file with comments | « blimp/engine/session/blimp_engine_session.cc ('k') | blimp/net/blimp_message_checkpointer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698