Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: blimp/engine/feature/engine_settings_feature.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/feature/engine_settings_feature.cc
diff --git a/blimp/engine/feature/engine_settings_feature.cc b/blimp/engine/feature/engine_settings_feature.cc
index 65572c567cc3b275cfb31f31293bc4e517db8727..520d165580b654906e68a3ddfd421668883669d2 100644
--- a/blimp/engine/feature/engine_settings_feature.cc
+++ b/blimp/engine/feature/engine_settings_feature.cc
@@ -25,8 +25,7 @@ EngineSettingsFeature::~EngineSettingsFeature() {}
void EngineSettingsFeature::ProcessMessage(
std::unique_ptr<BlimpMessage> message,
const net::CompletionCallback& callback) {
- DCHECK_EQ(message->type(), BlimpMessage::SETTINGS);
- DCHECK(message->has_settings());
+ DCHECK_EQ(BlimpMessage::kSettings, message->feature_case());
const SettingsMessage& settings = message->settings();
DCHECK(settings.has_engine_settings());
« no previous file with comments | « blimp/engine/feature/engine_render_widget_feature_unittest.cc ('k') | blimp/engine/session/blimp_engine_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698