Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2155)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: blimp/net/engine_authentication_handler.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« blimp/net/blimp_message_output_buffer.cc ('K') | « blimp/net/browser_connection_handler_unittest.cc ('k') | blimp/net/input_message_unittest.cc » ('j') | blimp/net/thread_pipe_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/net/engine_authentication_handler.cc
diff --git a/blimp/net/engine_authentication_handler.cc b/blimp/net/engine_authentication_handler.cc
index 798ac87936146d4e103a8ed6a5ea505a5090fb40..00b04239aa5ce514be11c71fb9216d00514c107b 100644
--- a/blimp/net/engine_authentication_handler.cc
+++ b/blimp/net/engine_authentication_handler.cc
@@ -111,7 +111,7 @@ void Authenticator::OnConnectionError(int error) {
void Authenticator::ProcessMessage(std::unique_ptr<BlimpMessage> message,
const net::CompletionCallback& callback) {
- if (message->type() == BlimpMessage::PROTOCOL_CONTROL &&
+ if (message->has_protocol_control() &&
Kevin M 2016/05/02 17:47:48 Check case
shaktisahu 2016/05/16 20:19:03 Done.
message->protocol_control().type() ==
ProtocolControlMessage::START_CONNECTION) {
bool token_match =
« blimp/net/blimp_message_output_buffer.cc ('K') | « blimp/net/browser_connection_handler_unittest.cc ('k') | blimp/net/input_message_unittest.cc » ('j') | blimp/net/thread_pipe_manager_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698