Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: blimp/net/blimp_message_checkpointer.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« blimp/engine/session/blimp_engine_session.cc ('K') | « blimp/net/blimp_connection_unittest.cc ('k') | blimp/net/blimp_message_checkpointer_unittest.cc » ('j') | blimp/net/blimp_message_output_buffer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/net/blimp_message_checkpointer.cc
diff --git a/blimp/net/blimp_message_checkpointer.cc b/blimp/net/blimp_message_checkpointer.cc
index c9a20c37c6e4903e578d79fb90feac5d0304cafe..898355b51d23f54ef1abeb3bd35790ec590246a2 100644
--- a/blimp/net/blimp_message_checkpointer.cc
+++ b/blimp/net/blimp_message_checkpointer.cc
@@ -35,7 +35,7 @@ BlimpMessageCheckpointer::~BlimpMessageCheckpointer() {}
void BlimpMessageCheckpointer::ProcessMessage(
std::unique_ptr<BlimpMessage> message,
const net::CompletionCallback& callback) {
- if (message->type() == BlimpMessage::PROTOCOL_CONTROL &&
+ if (message->has_protocol_control() &&
Kevin M 2016/05/02 17:47:48 Check the case
shaktisahu 2016/05/16 20:19:02 I am checking the case it only in DCHECK
message->protocol_control().type() ==
ProtocolControlMessage::CHECKPOINT_ACK) {
if (message->protocol_control().has_checkpoint_ack() &&
« blimp/engine/session/blimp_engine_session.cc ('K') | « blimp/net/blimp_connection_unittest.cc ('k') | blimp/net/blimp_message_checkpointer_unittest.cc » ('j') | blimp/net/blimp_message_output_buffer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698