blimp/common/proto/tab_control.proto - Issue 1933053003: Used oneof in blimp_message.proto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/common/proto/tab_control.proto

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/common/proto/tab_control.proto

diff --git a/blimp/common/proto/tab_control.proto b/blimp/common/proto/tab_control.proto

index 53d66ee3a6406f3c63e0dd8049a8a94b5a7ee87d..9bd95a833e5dca227b471fa907c220ccd98fb385 100644

--- a/blimp/common/proto/tab_control.proto

+++ b/blimp/common/proto/tab_control.proto

@@ -33,8 +33,5 @@ message TabControlMessage {

optional Type type = 1;

// Feature-specific messages follow.

- // Only one of these fields may be set per TabControlMessage.

- // TODO(kmarshall): use a 'oneof' union when it's supported in Chromium. See

- // crbug.com/570371.

optional SizeMessage size = 1000;

}