Used oneof in blimp_message.proto

blimp/client/feature/ime_feature.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/client/feature/ime_feature.h"
 
 #include <string>
 
 #include "blimp/common/create_blimp_message.h"
 #include "blimp/common/proto/blimp_message.pb.h"
@@ skipping 18 matching lines @@
   ime_message->set_type(ImeMessage::SET_TEXT);
   ime_message->set_ime_text(text);
 
   outgoing_message_processor_->ProcessMessage(std::move(blimp_message),
                                               net::CompletionCallback());
 }
 
 void ImeFeature::ProcessMessage(std::unique_ptr<BlimpMessage> message,
                                 const net::CompletionCallback& callback) {
   DCHECK(!callback.is_null());
-  DCHECK_EQ(BlimpMessage::IME, message->type());
+  DCHECK_EQ(BlimpMessage::kIme, message->feature_case());

[Wez, 2016/05/18 01:53:31]

Wouldn't it be cleaner to DCHECK(message->has_ime()), and similarly across the
other files?

[shaktisahu, 2016/05/18 03:55:42]

As we discussed, it is better to keep the DCHECK_EQ since it provides extra
information.

 
   DCHECK(delegate_);
 
   const ImeMessage& ime_message = message->ime();
 
   switch (ime_message.type()) {
     case ImeMessage::SHOW_IME:
       if (!message->has_target_tab_id() || message->target_tab_id() < 0 ||
           ime_message.render_widget_id() <= 0) {
         callback.Run(net::ERR_INVALID_ARGUMENT);
@@ skipping 18 matching lines @@
       NOTREACHED();
       callback.Run(net::ERR_UNEXPECTED);
       return;
   }
 
   callback.Run(net::OK);
 }
 
 }  // namespace client
 }  // namespace blimp