Issue 1933033002: Don't run PerformCheckpoint on Document::finishedParsing while running JS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1933033002: Don't run PerformCheckpoint on Document::finishedParsing while running JS (Closed)

Created:
4 years, 7 months ago by kozy

Modified:
4 years, 6 months ago

Reviewers:
kouhei (in TOK)

CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-dom_chromium.org, sof, eae+blinkwatch, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, rwlbuis, kozyatinskiy+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Don't run PerformCheckpoint on Document::finishedParsing while running JS It's speculative solution. Without this CL DOMParser().parseFromString('hi', 'text/html') will produce execution of async tasks BUG=606986 R=kouhei@chromium.org

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -1 line)			Patch
A	third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-promise-run-after-script.html	View	1 chunk	+33 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-promise-run-after-script-expected.txt	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/dom/Document.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kozy

4 years, 7 months ago (2016-04-29 02:25:55 UTC) #1

@kouhei, please take a look.
It's related to crbug.com/425790

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages