Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: media/filters/vpx_video_decoder.cc

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/vpx_video_decoder.h ('k') | media/midi/usb_midi_device_factory_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/vpx_video_decoder.cc
diff --git a/media/filters/vpx_video_decoder.cc b/media/filters/vpx_video_decoder.cc
index df314ec2c1e10dab43b8ff17a886b5f8ca71d620..ecef96cf1684e192a44b116deba543ae36fc5d91 100644
--- a/media/filters/vpx_video_decoder.cc
+++ b/media/filters/vpx_video_decoder.cc
@@ -204,11 +204,9 @@ void VpxVideoDecoder::MemoryPool::OnVideoFrameDestroyed(
VpxVideoDecoder::VpxVideoDecoder(
const scoped_refptr<base::SingleThreadTaskRunner>& task_runner)
: task_runner_(task_runner),
- weak_factory_(this),
state_(kUninitialized),
vpx_codec_(NULL),
- vpx_codec_alpha_(NULL) {
-}
+ vpx_codec_alpha_(NULL) {}
VpxVideoDecoder::~VpxVideoDecoder() {
DCHECK_EQ(kUninitialized, state_);
@@ -223,8 +221,6 @@ void VpxVideoDecoder::Initialize(const VideoDecoderConfig& config,
DCHECK(decode_cb_.is_null());
DCHECK(reset_cb_.is_null());
- weak_this_ = weak_factory_.GetWeakPtr();
-
if (!ConfigureDecoder(config)) {
status_cb.Run(DECODER_ERROR_NOT_SUPPORTED);
return;
« no previous file with comments | « media/filters/vpx_video_decoder.h ('k') | media/midi/usb_midi_device_factory_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698