Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: media/filters/ffmpeg_video_decoder.cc

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/ffmpeg_video_decoder.h ('k') | media/filters/gpu_video_decoder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/ffmpeg_video_decoder.cc
diff --git a/media/filters/ffmpeg_video_decoder.cc b/media/filters/ffmpeg_video_decoder.cc
index ff14e89d3711196a713a3e562ee2d975fae758d9..d52bc71690232564c8c384fa7a79e1d098aab847 100644
--- a/media/filters/ffmpeg_video_decoder.cc
+++ b/media/filters/ffmpeg_video_decoder.cc
@@ -56,10 +56,7 @@ static int GetThreadCount(AVCodecID codec_id) {
FFmpegVideoDecoder::FFmpegVideoDecoder(
const scoped_refptr<base::SingleThreadTaskRunner>& task_runner)
- : task_runner_(task_runner),
- weak_factory_(this),
- state_(kUninitialized) {
-}
+ : task_runner_(task_runner), state_(kUninitialized) {}
int FFmpegVideoDecoder::GetVideoBuffer(AVCodecContext* codec_context,
AVFrame* frame) {
@@ -134,7 +131,6 @@ void FFmpegVideoDecoder::Initialize(const VideoDecoderConfig& config,
DCHECK(!config.is_encrypted());
FFmpegGlue::InitializeFFmpeg();
- weak_this_ = weak_factory_.GetWeakPtr();
config_ = config;
PipelineStatusCB initialize_cb = BindToCurrentLoop(status_cb);
« no previous file with comments | « media/filters/ffmpeg_video_decoder.h ('k') | media/filters/gpu_video_decoder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698