Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: media/filters/decoder_stream.h

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/decoder_selector.h ('k') | media/filters/decoder_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/decoder_stream.h
diff --git a/media/filters/decoder_stream.h b/media/filters/decoder_stream.h
index 5acd9daf9e487dd0ad1f1caaae65318770d46a2c..68bbfcd937df91d3eae5f4a1db1136507cef5c0c 100644
--- a/media/filters/decoder_stream.h
+++ b/media/filters/decoder_stream.h
@@ -147,7 +147,6 @@ class MEDIA_EXPORT DecoderStream {
void OnDecoderStopped();
scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
- base::WeakPtrFactory<DecoderStream<StreamType> > weak_factory_;
State state_;
@@ -166,6 +165,9 @@ class MEDIA_EXPORT DecoderStream {
scoped_ptr<Decoder> decoder_;
scoped_ptr<DecryptingDemuxerStream> decrypting_demuxer_stream_;
+ // NOTE: Weak pointers must be invalidated before all other member variables.
+ base::WeakPtrFactory<DecoderStream<StreamType> > weak_factory_;
+
// This is required so the VideoFrameStream can access private members in
// FinishInitialization() and ReportStatistics().
DISALLOW_IMPLICIT_CONSTRUCTORS(DecoderStream);
« no previous file with comments | « media/filters/decoder_selector.h ('k') | media/filters/decoder_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698