media/cast/video_sender/external_video_encoder.h - Issue 193303002: WeakPtr destruction order cleanup: media edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/video_sender/external_video_encoder.h

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/cast/video_sender/external_video_encoder.h

diff --git a/media/cast/video_sender/external_video_encoder.h b/media/cast/video_sender/external_video_encoder.h

index 446cac5a4d4e666d1576ce91a799b47d69fe89cc..6c4c97e92207c881728c6f16ae161d5d30c04643 100644

--- a/media/cast/video_sender/external_video_encoder.h

+++ b/media/cast/video_sender/external_video_encoder.h

@@ -71,6 +71,7 @@ class ExternalVideoEncoder : public VideoEncoder {

// Weak pointer factory for posting back LocalVideoEncodeAcceleratorClient

// notifications to ExternalVideoEncoder.

+ // NOTE: Weak pointers must be invalidated before all other member variables.

base::WeakPtrFactory<ExternalVideoEncoder> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(ExternalVideoEncoder);

« no previous file with comments | « media/cast/video_receiver/video_receiver.h ('k') | media/cast/video_sender/video_sender.h » ('j') | no next file with comments »