media/cast/audio_sender/audio_encoder.cc - Issue 193303002: WeakPtr destruction order cleanup: media edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/audio_sender/audio_encoder.cc

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/cast/audio_sender/audio_encoder.cc

diff --git a/media/cast/audio_sender/audio_encoder.cc b/media/cast/audio_sender/audio_encoder.cc

index a1b0c95645b8821afc8750116ab0f9535b099325..ece368f65415fc3c51e027a44cd06d79ecbca5f4 100644

--- a/media/cast/audio_sender/audio_encoder.cc

+++ b/media/cast/audio_sender/audio_encoder.cc

@@ -167,9 +167,9 @@ class AudioEncoder::ImplBase

// so far.

uint32 rtp_timestamp_;

+ // NOTE: Weak pointers must be invalidated before all other member variables.

base::WeakPtrFactory<ImplBase> weak_factory_;

- private:

DISALLOW_COPY_AND_ASSIGN(ImplBase);

};

« no previous file with comments | « media/cast/audio_receiver/audio_receiver.h ('k') | media/cast/audio_sender/audio_sender.h » ('j') | no next file with comments »