Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Unified Diff: media/base/text_renderer.h

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/serial_runner.cc ('k') | media/base/text_renderer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/text_renderer.h
diff --git a/media/base/text_renderer.h b/media/base/text_renderer.h
index dab18e6671c64026b0fb8603e0e59a588363bc10..ce109125565acc27251119a5634332889601e270 100644
--- a/media/base/text_renderer.h
+++ b/media/base/text_renderer.h
@@ -105,8 +105,6 @@ class MEDIA_EXPORT TextRenderer {
void Read(TextTrackState* state, DemuxerStream* text_stream);
scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
- base::WeakPtrFactory<TextRenderer> weak_factory_;
- base::WeakPtr<TextRenderer> weak_this_;
const AddTextTrackCB add_text_track_cb_;
// Callbacks provided during Initialize().
@@ -140,6 +138,9 @@ class MEDIA_EXPORT TextRenderer {
typedef std::set<DemuxerStream*> PendingEosSet;
PendingEosSet pending_eos_set_;
+ // NOTE: Weak pointers must be invalidated before all other member variables.
+ base::WeakPtrFactory<TextRenderer> weak_factory_;
+
DISALLOW_IMPLICIT_CONSTRUCTORS(TextRenderer);
};
« no previous file with comments | « media/base/serial_runner.cc ('k') | media/base/text_renderer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698