media/base/serial_runner.h - Issue 193303002: WeakPtr destruction order cleanup: media edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/serial_runner.h

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/serial_runner.h

diff --git a/media/base/serial_runner.h b/media/base/serial_runner.h

index 44300dc1d96ac25a62d6dfbe9fabdb3c04cfab7b..6d3d1996593f7cbb686971bb024893440add9a56 100644

--- a/media/base/serial_runner.h

+++ b/media/base/serial_runner.h

@@ -71,11 +71,13 @@ class MEDIA_EXPORT SerialRunner {

void RunNextInSeries(PipelineStatus last_status);

- base::WeakPtrFactory<SerialRunner> weak_this_;

scoped_refptr<base::SingleThreadTaskRunner> task_runner_;

Queue bound_fns_;

PipelineStatusCB done_cb_;

+ // NOTE: Weak pointers must be invalidated before all other member variables.

+ base::WeakPtrFactory<SerialRunner> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(SerialRunner);

};

« no previous file with comments | « media/base/android/media_source_player.cc ('k') | media/base/serial_runner.cc » ('j') | no next file with comments »