Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: content/renderer/media/video_capture_impl_manager.h

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/video_capture_impl.cc ('k') | content/renderer/media/webaudiosourceprovider_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/video_capture_impl_manager.h
diff --git a/content/renderer/media/video_capture_impl_manager.h b/content/renderer/media/video_capture_impl_manager.h
index 9a5e0c26472e313b91216606c0843171c4bac272..6b02825a7aa9e549fc72da4c79075f962f988fc5 100644
--- a/content/renderer/media/video_capture_impl_manager.h
+++ b/content/renderer/media/video_capture_impl_manager.h
@@ -101,10 +101,13 @@ class CONTENT_EXPORT VideoCaptureImplManager {
scoped_refptr<VideoCaptureMessageFilter> filter_;
- // Following two members are bound to the render thread.
- base::WeakPtrFactory<VideoCaptureImplManager> weak_factory_;
+ // Bound to the render thread.
base::ThreadChecker thread_checker_;
+ // Bound to the render thread.
+ // NOTE: Weak pointers must be invalidated before all other member variables.
+ base::WeakPtrFactory<VideoCaptureImplManager> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(VideoCaptureImplManager);
};
« no previous file with comments | « content/renderer/media/video_capture_impl.cc ('k') | content/renderer/media/webaudiosourceprovider_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698