content/renderer/media/buffered_data_source.h - Issue 193303002: WeakPtr destruction order cleanup: media edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/buffered_data_source.h

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/buffered_data_source.h

diff --git a/content/renderer/media/buffered_data_source.h b/content/renderer/media/buffered_data_source.h

index 30991dd2796f16b2a670119f7d40bce47e820e14..40e549d900f7cb0688c280c797c6446890ab7358 100644

--- a/content/renderer/media/buffered_data_source.h

+++ b/content/renderer/media/buffered_data_source.h

@@ -139,8 +139,6 @@ class CONTENT_EXPORT BufferedDataSource : public media::DataSource {

// change in playback rate.

void UpdateDeferStrategy(bool paused);

- base::WeakPtr<BufferedDataSource> weak_this_;

// URL of the resource requested.

GURL url_;

// crossorigin attribute on the corresponding HTML media element, if any.

@@ -216,6 +214,7 @@ class CONTENT_EXPORT BufferedDataSource : public media::DataSource {

DownloadingCB downloading_cb_;

+ // NOTE: Weak pointers must be invalidated before all other member variables.

base::WeakPtrFactory<BufferedDataSource> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(BufferedDataSource);