Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: content/browser/media/android/media_resource_getter_impl.cc

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/android/media_resource_getter_impl.cc
diff --git a/content/browser/media/android/media_resource_getter_impl.cc b/content/browser/media/android/media_resource_getter_impl.cc
index 643c690a8c397d0b017c8ebc7ddef39ef1c43c8e..919ee845693634da16c14ece43ab697f4a750985 100644
--- a/content/browser/media/android/media_resource_getter_impl.cc
+++ b/content/browser/media/android/media_resource_getter_impl.cc
@@ -200,13 +200,13 @@ void CookieGetterTask::CheckPolicyForCookies(
MediaResourceGetterImpl::MediaResourceGetterImpl(
BrowserContext* browser_context,
fileapi::FileSystemContext* file_system_context,
- int renderer_id, int routing_id)
+ int renderer_id,
+ int routing_id)
: browser_context_(browser_context),
file_system_context_(file_system_context),
- weak_this_(this),
renderer_id_(renderer_id),
- routing_id_(routing_id) {
-}
+ routing_id_(routing_id),
+ weak_factory_(this) {}
MediaResourceGetterImpl::~MediaResourceGetterImpl() {}
@@ -218,7 +218,8 @@ void MediaResourceGetterImpl::GetCookies(
browser_context_, renderer_id_, routing_id_);
GetCookieCB cb = base::Bind(&MediaResourceGetterImpl::GetCookiesCallback,
- weak_this_.GetWeakPtr(), callback);
+ weak_factory_.GetWeakPtr(),
+ callback);
BrowserThread::PostTask(
BrowserThread::IO,
FROM_HERE,
@@ -238,9 +239,10 @@ void MediaResourceGetterImpl::GetPlatformPathFromURL(
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
DCHECK(url.SchemeIsFileSystem() || url.SchemeIs(kBlobScheme));
- GetPlatformPathCB cb = base::Bind(
- &MediaResourceGetterImpl::GetPlatformPathCallback,
- weak_this_.GetWeakPtr(), callback);
+ GetPlatformPathCB cb =
+ base::Bind(&MediaResourceGetterImpl::GetPlatformPathCallback,
+ weak_factory_.GetWeakPtr(),
+ callback);
if (url.SchemeIs(kBlobScheme)) {
BrowserThread::PostTask(

Powered by Google App Engine
This is Rietveld 408576698