Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: media/filters/video_renderer_impl.cc

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/video_renderer_impl.cc
diff --git a/media/filters/video_renderer_impl.cc b/media/filters/video_renderer_impl.cc
index e697a8355978848ea30f827353e794d1e5e4c5dd..6ead2d17974751d07512c940362044b4cf55eee9 100644
--- a/media/filters/video_renderer_impl.cc
+++ b/media/filters/video_renderer_impl.cc
@@ -30,9 +30,7 @@ VideoRendererImpl::VideoRendererImpl(
const SetOpaqueCB& set_opaque_cb,
bool drop_frames)
: task_runner_(task_runner),
- weak_factory_(this),
- video_frame_stream_(
- task_runner, decoders.Pass(), set_decryptor_ready_cb),
+ video_frame_stream_(task_runner, decoders.Pass(), set_decryptor_ready_cb),
received_end_of_stream_(false),
frame_available_(&lock_),
state_(kUninitialized),
@@ -44,7 +42,8 @@ VideoRendererImpl::VideoRendererImpl(
set_opaque_cb_(set_opaque_cb),
last_timestamp_(kNoTimestamp()),
frames_decoded_(0),
- frames_dropped_(0) {
+ frames_dropped_(0),
+ weak_factory_(this) {
DCHECK(!paint_cb_.is_null());
}

Powered by Google App Engine
This is Rietveld 408576698