media/filters/ffmpeg_video_decoder.cc - Issue 193303002: WeakPtr destruction order cleanup: media edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/ffmpeg_video_decoder.cc

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/ffmpeg_video_decoder.cc

diff --git a/media/filters/ffmpeg_video_decoder.cc b/media/filters/ffmpeg_video_decoder.cc

index ff14e89d3711196a713a3e562ee2d975fae758d9..16653524a6305d255602cc2b62fe5e389e1ac36c 100644

--- a/media/filters/ffmpeg_video_decoder.cc

+++ b/media/filters/ffmpeg_video_decoder.cc

@@ -56,10 +56,7 @@ static int GetThreadCount(AVCodecID codec_id) {

FFmpegVideoDecoder::FFmpegVideoDecoder(

const scoped_refptr<base::SingleThreadTaskRunner>& task_runner)

- : task_runner_(task_runner),

- weak_factory_(this),

- state_(kUninitialized) {

+ : task_runner_(task_runner), state_(kUninitialized), weak_factory_(this) {}

int FFmpegVideoDecoder::GetVideoBuffer(AVCodecContext* codec_context,

AVFrame* frame) {