Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: content/renderer/media/cdm_session_adapter.h

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/cdm_session_adapter.h
diff --git a/content/renderer/media/cdm_session_adapter.h b/content/renderer/media/cdm_session_adapter.h
index 611f25b5038cb12c99d83a1ddf4399e81fb9b429..38ad075d8e89e8f1ddf8229a111eb38027dc5635 100644
--- a/content/renderer/media/cdm_session_adapter.h
+++ b/content/renderer/media/cdm_session_adapter.h
@@ -87,13 +87,15 @@ class CdmSessionAdapter : public base::RefCounted<CdmSessionAdapter> {
scoped_ptr<media::MediaKeys> media_keys_;
- base::WeakPtrFactory<CdmSessionAdapter> weak_ptr_factory_;
-
SessionMap sessions_;
// Session ID should be unique per renderer process for debugging purposes.
static uint32 next_session_id_;
+ // NOTE: This must always be last so it's invalidated before other member
+ // variables might be accessed.
+ base::WeakPtrFactory<CdmSessionAdapter> weak_ptr_factory_;
+
DISALLOW_COPY_AND_ASSIGN(CdmSessionAdapter);
};

Powered by Google App Engine
This is Rietveld 408576698