content/browser/media/android/browser_media_player_manager.h - Issue 193303002: WeakPtr destruction order cleanup: media edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/android/browser_media_player_manager.h

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/media/android/browser_media_player_manager.h

diff --git a/content/browser/media/android/browser_media_player_manager.h b/content/browser/media/android/browser_media_player_manager.h

index 8df9945d2eec6e1bbbf2faa22603accf007f8586..854dfd1131b309b80fcbccbdb45b05ef20a501da 100644

--- a/content/browser/media/android/browser_media_player_manager.h

+++ b/content/browser/media/android/browser_media_player_manager.h

@@ -245,6 +245,8 @@ class CONTENT_EXPORT BrowserMediaPlayerManager

// Object for retrieving resources media players.

scoped_ptr<media::MediaResourceGetter> media_resource_getter_;

+ // NOTE: This must always be last so it's invalidated before other member

+ // variables might be accessed.

base::WeakPtrFactory<BrowserMediaPlayerManager> weak_ptr_factory_;

DISALLOW_COPY_AND_ASSIGN(BrowserMediaPlayerManager);