Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: content/browser/media/android/browser_media_player_manager.h

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | content/browser/media/android/media_resource_getter_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_MEDIA_ANDROID_BROWSER_MEDIA_PLAYER_MANAGER_H_ 5 #ifndef CONTENT_BROWSER_MEDIA_ANDROID_BROWSER_MEDIA_PLAYER_MANAGER_H_
6 #define CONTENT_BROWSER_MEDIA_ANDROID_BROWSER_MEDIA_PLAYER_MANAGER_H_ 6 #define CONTENT_BROWSER_MEDIA_ANDROID_BROWSER_MEDIA_PLAYER_MANAGER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 int pending_fullscreen_player_id_; 238 int pending_fullscreen_player_id_;
239 239
240 // Whether the fullscreen player has been Release()-d. 240 // Whether the fullscreen player has been Release()-d.
241 bool fullscreen_player_is_released_; 241 bool fullscreen_player_is_released_;
242 242
243 WebContents* web_contents_; 243 WebContents* web_contents_;
244 244
245 // Object for retrieving resources media players. 245 // Object for retrieving resources media players.
246 scoped_ptr<media::MediaResourceGetter> media_resource_getter_; 246 scoped_ptr<media::MediaResourceGetter> media_resource_getter_;
247 247
248 // NOTE: Weak pointers must be invalidated before all other member variables.
248 base::WeakPtrFactory<BrowserMediaPlayerManager> weak_ptr_factory_; 249 base::WeakPtrFactory<BrowserMediaPlayerManager> weak_ptr_factory_;
249 250
250 DISALLOW_COPY_AND_ASSIGN(BrowserMediaPlayerManager); 251 DISALLOW_COPY_AND_ASSIGN(BrowserMediaPlayerManager);
251 }; 252 };
252 253
253 } // namespace content 254 } // namespace content
254 255
255 #endif // CONTENT_BROWSER_MEDIA_ANDROID_BROWSER_MEDIA_PLAYER_MANAGER_H_ 256 #endif // CONTENT_BROWSER_MEDIA_ANDROID_BROWSER_MEDIA_PLAYER_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/media/android/media_resource_getter_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698