WeakPtr destruction order cleanup: media edition.

media/filters/opus_audio_decoder.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_FILTERS_OPUS_AUDIO_DECODER_H_
 #define MEDIA_FILTERS_OPUS_AUDIO_DECODER_H_
 
 #include "base/callback.h"
 #include "base/memory/weak_ptr.h"
 #include "base/time/time.h"
@@ skipping 40 matching lines @@
   void BufferReady(DemuxerStream::Status status,
                    const scoped_refptr<DecoderBuffer>& input);
 
   bool ConfigureDecoder();
   void CloseDecoder();
   void ResetTimestampState();
   bool Decode(const scoped_refptr<DecoderBuffer>& input,
               scoped_refptr<AudioBuffer>* output_buffer);
 
   scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
-  base::WeakPtrFactory<OpusAudioDecoder> weak_factory_;
-  base::WeakPtr<OpusAudioDecoder> weak_this_;
 
   DemuxerStream* demuxer_stream_;
   StatisticsCB statistics_cb_;
   OpusMSDecoder* opus_decoder_;
 
   // Decoded audio format.
   ChannelLayout channel_layout_;
   int samples_per_second_;
   const SampleFormat sample_format_;
   const int bits_per_channel_;
@@ skipping 16 matching lines @@
   // Number of frames to be discarded at the start of the stream. This value
   // is typically the CodecDelay value from the container.  This value should
   // only be applied when input timestamp is |start_input_timestamp_|.
   int frame_delay_at_start_;
   base::TimeDelta start_input_timestamp_;
 
   // Timestamp to be subtracted from all the frames. This is typically computed
   // from the CodecDelay value in the container.
   base::TimeDelta timestamp_offset_;
 
+  // NOTE: These must always be last so they're invalidated before other member
+  // variables might be accessed.
+  base::WeakPtr<OpusAudioDecoder> weak_this_;

[Ami GONE FROM CHROMIUM, 2014/03/10 22:02:08]

ditto

+  base::WeakPtrFactory<OpusAudioDecoder> weak_factory_;
+
   DISALLOW_IMPLICIT_CONSTRUCTORS(OpusAudioDecoder);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_FILTERS_OPUS_AUDIO_DECODER_H_