WeakPtr destruction order cleanup: media edition.

media/cast/audio_sender/audio_sender.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/cast/audio_sender/audio_sender.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "media/cast/audio_sender/audio_encoder.h"
@@ skipping 68 matching lines @@
     rtp_timestamp_ = rtp_timestamp;
   }
 
  private:
   transport::CastTransportSender* const transport_sender_;
   int frequency_;
   transport::RtcpSenderInfo sender_info_;
   base::TimeTicks time_sent_;
   uint32 rtp_timestamp_;
 
+  // NOTE: This must always be last so it's invalidated before other member
+  // variables might be accessed.
   base::WeakPtrFactory<LocalRtpSenderStatistics> weak_factory_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(LocalRtpSenderStatistics);
 };
 
 // TODO(mikhal): Reduce heap allocation when not needed.
 AudioSender::AudioSender(scoped_refptr<CastEnvironment> cast_environment,
                          const AudioSenderConfig& audio_config,
                          transport::CastTransportSender* const transport_sender)
     : cast_environment_(cast_environment),
@@ skipping 107 matching lines @@
 }
 
 void AudioSender::ResendPacketsOnTransportThread(
     const transport::MissingFramesAndPacketsMap& missing_packets) {
   DCHECK(cast_environment_->CurrentlyOn(CastEnvironment::TRANSPORT));
   transport_sender_->ResendPackets(true, missing_packets);
 }
 
 }  // namespace cast
 }  // namespace media