WeakPtr destruction order cleanup: media edition.

media/audio/alsa/alsa_output.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Creates an output stream based on the ALSA PCM interface.
 //
 // On device write failure, the stream will move itself to an invalid state.
 // No more data will be pulled from the data source, or written to the device.
 // All calls to public API functions will either no-op themselves, or return an
 // error if possible.  Specifically, If the stream is in an error state, Open()
@@ skipping 183 matching lines @@
   // AudioManagerBase::ShutDown() can invalidate the message loop pointer
   // before the stream gets deleted.
   base::MessageLoop* message_loop_;
 
   // Handle to the actual PCM playback device.
   snd_pcm_t* playback_handle_;
 
   scoped_ptr<media::SeekableBuffer> buffer_;
   uint32 frames_per_packet_;
 
-  // Allows us to run tasks on the AlsaPcmOutputStream instance which are
-  // bound by its lifetime.
-  base::WeakPtrFactory<AlsaPcmOutputStream> weak_factory_;
-
   InternalState state_;
   float volume_;  // Volume level from 0.0 to 1.0.
 
   AudioSourceCallback* source_callback_;
 
   // Container for retrieving data from AudioSourceCallback::OnMoreData().
   scoped_ptr<AudioBus> audio_bus_;
 
   // Channel mixer and temporary bus for the final mixed channel data.
   scoped_ptr<ChannelMixer> channel_mixer_;
   scoped_ptr<AudioBus> mixed_audio_bus_;
 
+  // NOTE: This must always be last so it's invalidated before other member
+  // variables might be accessed.
+  base::WeakPtrFactory<AlsaPcmOutputStream> weak_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(AlsaPcmOutputStream);
 };
 
 MEDIA_EXPORT std::ostream& operator<<(std::ostream& os,
                                       AlsaPcmOutputStream::InternalState);
 
 };  // namespace media
 
 #endif  // MEDIA_AUDIO_ALSA_ALSA_OUTPUT_H_