Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Side by Side Diff: chrome/browser/resources/media_router/elements/route_details/route_details.js

Issue 1933013002: [Media Router WebUI] Remove unnecessary default property values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This Polymer element shows information from media that is currently cast 5 // This Polymer element shows information from media that is currently cast
6 // to a device. 6 // to a device.
7 Polymer({ 7 Polymer({
8 is: 'route-details', 8 is: 'route-details',
9 9
10 properties: { 10 properties: {
11 /** 11 /**
12 * The text for the current casting activity status. 12 * The text for the current casting activity status.
13 * @private {string} 13 * @private {string|undefined}
14 */ 14 */
15 activityStatus_: { 15 activityStatus_: {
16 type: String, 16 type: String,
17 value: '',
18 }, 17 },
19 18
20 /** 19 /**
21 * Whether the browser is currently incognito. 20 * Whether the browser is currently incognito.
22 * @type {boolean} 21 * @type {boolean|undefined}
23 */ 22 */
24 isOffTheRecord: { 23 isOffTheRecord: {
25 type: Boolean, 24 type: Boolean,
26 value: false,
27 }, 25 },
28 26
29 /** 27 /**
30 * The route to show. 28 * The route to show.
31 * @type {?media_router.Route} 29 * @type {?media_router.Route|undefined}
32 */ 30 */
33 route: { 31 route: {
34 type: Object, 32 type: Object,
35 value: null,
36 observer: 'maybeLoadCustomController_', 33 observer: 'maybeLoadCustomController_',
37 }, 34 },
38 35
39 /** 36 /**
40 * Whether the custom controller should be hidden. 37 * Whether the custom controller should be hidden.
41 * A custom controller is shown iff |route| specifies customControllerPath 38 * A custom controller is shown iff |route| specifies customControllerPath
42 * and the view can be loaded. 39 * and the view can be loaded.
43 * @private {boolean} 40 * @private {boolean}
44 */ 41 */
45 isCustomControllerHidden_: { 42 isCustomControllerHidden_: {
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 extensionview.load(this.route.customControllerPath) 100 extensionview.load(this.route.customControllerPath)
104 .then(function() { 101 .then(function() {
105 // Load was successful; show the custom controller. 102 // Load was successful; show the custom controller.
106 that.isCustomControllerHidden_ = false; 103 that.isCustomControllerHidden_ = false;
107 }, function() { 104 }, function() {
108 // Load was unsuccessful; fall back to default view. 105 // Load was unsuccessful; fall back to default view.
109 that.isCustomControllerHidden_ = true; 106 that.isCustomControllerHidden_ = true;
110 }); 107 });
111 }, 108 },
112 }); 109 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698