ChromeOS: chromeos should not depend on chromeos_test_support.

ChromeOS: chromeos should not depend on chromeos_test_support.

This Cl removes undesired chromeos build dependency on chromeos_test_support.

BUG=607742
TEST=none

Committed: https://crrev.com/3bd0a2304a53074ff1c76b6b82f7c68ec55a06a2
Cr-Commit-Position: refs/heads/master@{#390685}

[Alexander Alekseev, 2016-04-29 08:53:54]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 08:54:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1933003003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1933003003/1

[Alexander Alekseev, 2016-04-29 08:54:17]

alemate@chromium.org changed reviewers:
+ oshima@chromium.org

[Alexander Alekseev, 2016-04-29 09:09:39]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 09:09:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1933003003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1933003003/20001

[Alexander Alekseev, 2016-04-29 09:09:53]

Please review.

[commit-bot: I haz the power, 2016-04-29 09:16:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 09:16:39]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[oshima, 2016-04-29 11:49:47]

lgtm

Have you consider using TestURLFetcher? That could be a good alternative.

[Alexander Alekseev, 2016-04-29 17:25:29]

On 2016/04/29 11:49:47, oshima wrote:
> lgtm
> 
> Have you consider using TestURLFetcher? That could be a good alternative.

I needed the way to get an internal flag of SimpleGeolocationRequest.
I should have also added URL fetch test here, but decided that it is too much
for the test, because unit test already checks for the request data format and
what's included.

[Alexander Alekseev, 2016-04-29 17:25:39]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2016-04-29 17:25:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1933003003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1933003003/20001

[commit-bot: I haz the power, 2016-04-29 17:30:01]

Committed patchset #2 (id:20001)

[oshima, 2016-04-29 17:35:59]

On 2016/04/29 17:25:29, Alexander Alekseev wrote:
> On 2016/04/29 11:49:47, oshima wrote:
> > lgtm
> > 
> > Have you consider using TestURLFetcher? That could be a good alternative.
> 
> I needed the way to get an internal flag of SimpleGeolocationRequest.
> I should have also added URL fetch test here, but decided that it is too much
> for the test, because unit test already checks for the request data format and
> what's included.

You should be able to access SimpleGolocationRequest in the implementation of
URLTestFetcher::DelegateForTests.

Since this is just and interface, I don't have strong feeling about it though.

[commit-bot: I haz the power, 2016-04-30 17:26:49]

Patchset 2 (id:??) landed as
https://crrev.com/3bd0a2304a53074ff1c76b6b82f7c68ec55a06a2
Cr-Commit-Position: refs/heads/master@{#390685}

[commit-bot: I haz the power, 2016-04-30 18:01:15]

Description was changed from

==========
ChromeOS: chromeos should not depend on chromeos_test_support.

This Cl removes undesired chromeos build dependency on chromeos_test_support.

BUG=607742
TEST=none
==========

to

==========
ChromeOS: chromeos should not depend on chromeos_test_support.

This Cl removes undesired chromeos build dependency on chromeos_test_support.

BUG=607742
TEST=none

Committed: https://crrev.com/3bd0a2304a53074ff1c76b6b82f7c68ec55a06a2
Cr-Commit-Position: refs/heads/master@{#390685}
==========